fix(query): prefer proven-empty outer join build side - #20220
Draft
dantengsky wants to merge 1 commit into
Draft
Conversation
dantengsky
force-pushed
the
fix/outer-join-empty-cardinality-memo
branch
from
July 29, 2026 00:43
956e4f9 to
6f93a92
Compare
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 956e4f95e8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
dantengsky
added
C-improvement
dantengsky
force-pushed
the
fix/outer-join-empty-cardinality-memo
branch
from
July 29, 2026 00:59
6f93a92 to
38ef8a8
Compare
dantengsky
marked this pull request as draft
July 29, 2026 01:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This avoids blocking hash-build work on an expensive input when the other input is known to be empty. Non-zero estimates, two estimated zeros, and two proven zeros retain the existing commute behavior.
Tests
Validation:
PROTOC_INCLUDE=/usr/include cargo test -p databend-common-sql --lib(84 passed)PROTOC_INCLUDE=/usr/include cargo test -p databend-common-sql --test it(84 passed)PROTOC_INCLUDE=/usr/include cargo clippy -p databend-common-sql --all-targets -- -D warningscargo fmt --all -- --checkType of change
No migration, configuration change, or rollout action is required.
This change is